Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't protect public files path #9457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rachelwhitton
Copy link
Member

Fixes #9452

  • Warn against configuring public files path as a protected web path in pantheon.yml doc

@rachelwhitton rachelwhitton added Type: Quick Fix Issues that should be resolvable in a small PR Topic: Code Structure Related to Upstreams and other code structure details labels Feb 24, 2025
@rachelwhitton rachelwhitton self-assigned this Feb 24, 2025
@rachelwhitton rachelwhitton requested a review from a team as a code owner February 24, 2025 20:47
@rachelwhitton
Copy link
Member Author

@ccharlton can you review when convenient?

@ccharlton
Copy link
Contributor

I have seen a good use of this pattern in the field (by a partner) where adding deeper sub-folder paths within the WP uploads folder helps in certain use cases, so I'm seeing this a bit differently.

Please add the context of adding the top-level public files folder is unadvised, and subpaths are supported. That will help be clear for the more intermediate Composer setups I'm seeing in the field from a couple of WordPress projects we're attached to.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Code Structure Related to Upstreams and other code structure details Type: Quick Fix Issues that should be resolvable in a small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protected Web Paths: Help protect customers from accidentally adding public file folders
2 participants